Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add validation for allowed OS and Arch combinations #1103

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

kanngiesser
Copy link
Contributor

Add validation for Platform Object.

  • Allow only values which are valid for $GOOS and $GOARCH (required for func CurrentPlatform() to work)
  • Allow only values for which there is an OpenTofu release (required to download binaries, see brokerpakurl.go)

Update Brokerpak specification to list correct values for allowed OS and Arch

Checklist:

  • Have you added or updated tests to validate the changed functionality?
  • Have you added Release Notes in the docs repositories?
  • Have you followed the Conventional Commits specification?

docs: update description for platform object at brokerpak specification
@blgm blgm merged commit 468f677 into cloudfoundry:main Oct 1, 2024
8 checks passed
@blgm
Copy link
Member

blgm commented Oct 1, 2024

Thank you @kanngiesser

servicesenablement pushed a commit that referenced this pull request Oct 1, 2024
docs: update description for platform object at brokerpak specification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants